Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111495: Add tests for PyTuple C API #111606

Closed
wants to merge 11 commits into from

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Nov 1, 2023

Adding tests for PyTuple C API - Issue #111495

Signed-off-by: kalyanr <[email protected]>
@bedevere-app bedevere-app bot mentioned this pull request Nov 1, 2023
10 tasks
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Nov 1, 2023
@rawwar
Copy link
Contributor Author

rawwar commented Nov 1, 2023

Hello @serhiy-storchaka , I am not sure how to write tests for the following C API's. Can you please help me with some ideas. Thanks!

  1. PyTuple_Pack
  2. PyTuple_SetItem
  3. PyTuple_SET_ITEM
  4. PyTuple_Resize

@rawwar rawwar marked this pull request as ready for review November 1, 2023 19:27
@rawwar rawwar marked this pull request as draft November 4, 2023 04:01
@skirpichev
Copy link
Member

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

@rawwar
Copy link
Contributor Author

rawwar commented Feb 21, 2024

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

Thanks. I will go through them. Will be looking into this over the weekend

@rawwar
Copy link
Contributor Author

rawwar commented May 8, 2024

I won't be able to complete this PR at this time.

@rawwar rawwar closed this May 8, 2024
@skirpichev
Copy link
Member

I'll try to finish your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants