Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-114678: Fix incorrect deprecation warning for 'N' specifier in Decimal format #114683

Merged
merged 4 commits into from
Jan 29, 2024
Merged

gh-114678: Fix incorrect deprecation warning for 'N' specifier in Decimal format #114683

merged 4 commits into from
Jan 29, 2024
+20 −7

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 28, 2024 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 bug and security fixes label Jan 28, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2024
Closed
@rhettinger
Copy link
Contributor

I approved this but please still have Mark look at it as well.

ericvsmith
ericvsmith approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small point about the News entry, otherwise looks good to me.

Misc/NEWS.d/next/Library/2024-01-28-19-40-40.gh-issue-114678.kYKcJw.rst Outdated Show resolved Hide resolved
mdickinson
mdickinson approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson
Copy link
Member

I can't quite believe I missed this in the original PR. Apologies for that.

@serhiy-storchaka serhiy-storchaka merged commit aa3402a into python:main Jan 29, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the decimal-format-N branch January 29, 2024 17:58
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker aa3402ad451777d8dd3ec560e14cb16dc8540c0e 3.12

@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 bug and security fixes label Jan 29, 2024
@serhiy-storchaka serhiy-storchaka removed their assignment Jan 29, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @skrah @aisk
pythongh-114678: Fix incorrect deprecation warning for 'N' specifier …
6bf9720 
…in Decimal format (pythonGH-114683)

Co-authored-by: Stefan Krah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@mdickinson mdickinson mdickinson approved these changes

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @rhettinger @mdickinson @ericvsmith