gh-113317: Remove Argument Clinic global variable 'clinic' #114752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Clinic.warn() and Clinic.fail() methods. * Add filename parameter to BlockParser constructor. * Add BlockParser.fail() method. * Add DSLParser.fail() method. * Pass lineno parameter to DSLParser.format_docstring(): more accurate error reporting. * Convert a few DSLParser static methods to regular method to be able to call self.fail(). * Language.render() clinic parameter is now required: None is no longer accepted. * Remove warn() function. * Remove global variable 'clinic'. fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.
|
@erlend-aasland @AlexWaygood: Would you mind to review this change? @erlend-aasland wrote a different approach: Argument-Clinic#35 |
|
See also Argument-Clinic#36 |
|
I'm stepping down as an AC maintainer for now :) #114796 I trust you two to come to the right decision! |
Even if you're not officially an "expert" or "code owner", your opinion still matters for me, and you're free to pick some reviews whenever you want. But I understand that I should ping you less often on such AC changes ;-) |
|
Ping @erlend-aasland: Gentle reminder that I'm looking for a review :-) |
|
Superseded by #115517. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.