-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix dangling refs in bdb.rst #114983
Conversation
Co-authored-by: AN Long <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@smontanaro Please could you update this PR to remove
|
@hugovk Should be all set. If my aim at the start of one of these mini-projects is to get rid of all warnings from a file, should my initial PR remove it from |
Yes please, we can consider each PR to be atomic so both (clean file, remove from .nitignore) are needed for the CI to pass, and the CI must pass for us to be able to merge. |
Thanks @smontanaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @smontanaro and @hugovk, I could not cleanly backport this to
|
(cherry picked from commit 1b89591) Co-authored-by: Skip Montanaro <[email protected]> Co-authored-by: AN Long <[email protected]>
GH-115284 is a backport of this pull request to the 3.11 branch. |
gh-101100: Fix dangling refs in bdb.rst (GH-114983) (cherry picked from commit 1b89591) Co-authored-by: Skip Montanaro <[email protected]> Co-authored-by: AN Long <[email protected]>
Co-authored-by: AN Long <[email protected]> (cherry picked from commit 1b89591)
Cherries have been picked. I think I finally created the pull request against the correct branch (3.12). Given the standardized naming of the backport branch, it does seem peculiar that GitHub can't default to the relevant branch though... |
GH-115297 is a backport of this pull request to the 3.12 branch. |
Looks great! There was just one thing missing: a backport PR to the 3.12 branch has to have a PR title starting with |
Co-authored-by: AN Long <[email protected]> Fix dangling refs in bdb.rst (#114983)
Co-authored-by: AN Long <[email protected]>
This should be fairly straightforward. I did one thing that isn't maybe strictly kosher. The
Bdb.quitting
attribute isn't directly documented, but is mentioned in the description ofBdb.set_quit()
. I linked those occurrences to the description ofset_quit
.📚 Documentation preview 📚: https://cpython-previews--114983.org.readthedocs.build/