gh-115491: Keep some fields valid across allocations in obmalloc (free-threading) #115745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c (free-threading)
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…c (free-threading) (python#115745)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…c (free-threading) (python#115745)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids overwriting the first few fields in the
PyObjectheader with debug bytes (like0xDDfor dead bytes) in the free-threaded build. These fields may be accessed for a period after an object is deallocated.For simplicity, this skips some of the filling of debug bytes for the "realloc" calls in the free-threaded build, because that case is more complex. The calls that delegate to mimalloc will be filled by mimalloc with debug bytes anyways.
ob_tid,ob_ref_local, andob_ref_sharedfields valid across allocations in free-threaded build #115491