Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-115979: update test_importlib to work under WASI SDK 21 #116754

Merged
merged 8 commits into from
Mar 13, 2024
Merged

GH-115979: update test_importlib to work under WASI SDK 21 #116754

merged 8 commits into from
Mar 13, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 13, 2024 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Mar 13, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 13, 2024
Closed
@brettcannon brettcannon added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 13, 2024
@brettcannon brettcannon merged commit 61733a2 into python:main Mar 13, 2024
32 checks passed
@brettcannon brettcannon deleted the issue115979-test_importlib-wasi-sdk-21 branch March 13, 2024 20:24
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
@brettcannon @miss-islington
pythonGH-115979: update test_importlib to work under WASI SDK 21 (pyt…
8299816 
…honGH-116754)

(cherry picked from commit 61733a2)

Co-authored-by: Brett Cannon <[email protected]>
@miss-islington-app
Copy link

Sorry, @brettcannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61733a2fb9dc36d2246d922146a3462a2248832d 3.11

@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116759 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116762 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 13, 2024
brettcannon added a commit that referenced this pull request Mar 13, 2024
@miss-islington @brettcannon
[3.12] GH-115979: update test_importlib to work under WASI SDK 21 (GH…
0cc5047 
…-116754) (GH-116759)

GH-115979: update test_importlib to work under WASI SDK 21 (GH-116754)
(cherry picked from commit 61733a2)

Co-authored-by: Brett Cannon <[email protected]>
brettcannon added a commit that referenced this pull request Mar 13, 2024
@brettcannon
[3.11] GH-115979: update test_importlib to work under WASI SDK 21 (GH…
3cc24f1 
…-116754) (GH-116762)

(cherry picked from commit 61733a2)
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@brettcannon @vstinner
pythonGH-115979: update test_importlib to work under WASI SDK 21 (pyt…
c24c0eb 
…honGH-116754)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@brettcannon @adorilson
pythonGH-115979: update test_importlib to work under WASI SDK 21 (pyt…
175916c 
…honGH-116754)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@brettcannon @diegorusso
pythonGH-115979: update test_importlib to work under WASI SDK 21 (pyt…
aad8d62 
…honGH-116754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brettcannon