Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119127: functools.partial placeholders #119827

Merged
merged 78 commits into from
Sep 26, 2024
Merged

gh-119127: functools.partial placeholders #119827

merged 78 commits into from
Sep 26, 2024

Commits on May 21, 2024

  1. Initial Implementation

    @dg-pb
    dg-pb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ee7333c View commit details
    Browse the repository at this point in the history

  2. serialization fix

    @dg-pb
    dg-pb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8bcc462 View commit details
    Browse the repository at this point in the history

  3. bug fix

    @dg-pb
    dg-pb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c67c9b4 View commit details
    Browse the repository at this point in the history

  4. Bug 2 fix

    @dg-pb
    dg-pb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    680d900 View commit details
    Browse the repository at this point in the history

  5. Py_TPFLAGS_IMMUTABLETYPE added

    @dg-pb
    dg-pb committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9591ff5 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. placeholder added to state as opposed to being used as global constant

    @dg-pb
    dg-pb committed May 23, 2024
    Configuration menu
    Copy the full SHA
    067e938 View commit details
    Browse the repository at this point in the history

  2. static removed

    @dg-pb
    dg-pb committed May 23, 2024
    Configuration menu
    Copy the full SHA
    8af20b3 View commit details
    Browse the repository at this point in the history

  3. creating sentinel via PyType_Spec

    @dg-pb
    dg-pb committed May 23, 2024
    Configuration menu
    Copy the full SHA
    607a0b1 View commit details
    Browse the repository at this point in the history

  4. more accurate variable name

    @dg-pb
    dg-pb committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f55801e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. trailing trim bug and tests

    @dg-pb
    dg-pb committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5894145 View commit details
    Browse the repository at this point in the history

  2. Updated docs

    @dg-pb
    dg-pb committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3722e07 View commit details
    Browse the repository at this point in the history

  3. blurb

    @dg-pb
    dg-pb committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a79c2af View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into implement-119127

    d.grigonis authored May 24, 2024
    Configuration menu
    Copy the full SHA
    12aaa72 View commit details
    Browse the repository at this point in the history

  5. minor edit

    @dg-pb
    dg-pb committed May 24, 2024
    Configuration menu
    Copy the full SHA
    92c767b View commit details
    Browse the repository at this point in the history

  6. doc fix

    @dg-pb
    dg-pb committed May 24, 2024
    Configuration menu
    Copy the full SHA
    496a9d2 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. better variable names and mini corrections

    @dg-pb
    dg-pb committed May 31, 2024
    Configuration menu
    Copy the full SHA
    38d9c11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'implement-119127' into implement-119127-again

    @dg-pb
    dg-pb committed May 31, 2024
    Configuration menu
    Copy the full SHA
    707b957 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. review comments mostly

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    14b38ca View commit details
    Browse the repository at this point in the history

  2. singleton sentinel and reduce

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    32bca19 View commit details
    Browse the repository at this point in the history

  3. python module sentinel better mimics the one of the extension

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    8576493 View commit details
    Browse the repository at this point in the history

  4. Emulated None behaviour, but using PyType_FromModuleAndSpec

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    a3fd2d6 View commit details
    Browse the repository at this point in the history

  5. review feedback

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    0852993 View commit details
    Browse the repository at this point in the history

  6. included constant into tsv

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    6fea348 View commit details
    Browse the repository at this point in the history

  7. documentation update

    @dg-pb
    dg-pb committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    caec6e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. review edits

    @dg-pb
    dg-pb committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    115b8c5 View commit details
    Browse the repository at this point in the history

  2. trailing placeholder prohibition and small changes

    @dg-pb
    dg-pb committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    3f5f00b View commit details
    Browse the repository at this point in the history

  3. change constant name in ignores

    @dg-pb
    dg-pb committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    202c929 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. PlaceholderType Hidden

    @dg-pb
    dg-pb committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2c16d38 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. support 4-arg pre-placeholder state

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    400ff55 View commit details
    Browse the repository at this point in the history

  2. better variable names

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8ccc38f View commit details
    Browse the repository at this point in the history

  3. partialmethod impl

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e7c82c7 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c9b7ef3 View commit details
    Browse the repository at this point in the history

  5. adjust inspect to partial Placeholders

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e59d711 View commit details
    Browse the repository at this point in the history

  6. arg alignment

    @dg-pb
    dg-pb committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7bfc591 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. small fixes

    @dg-pb
    dg-pb committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7957a97 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. pickle compatibility ensured

    @dg-pb
    dg-pb committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    8aaee6a View commit details
    Browse the repository at this point in the history

  2. trailing placeholder test for __setstate__

    @dg-pb
    dg-pb committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    fe8e0ad View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. rough implementation rolled back and example of successive applicatio… 

    …ns added
    @dg-pb
    dg-pb committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    00dd80e View commit details
    Browse the repository at this point in the history

  2. small doc edits

    @dg-pb
    dg-pb committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d352cfa View commit details
    Browse the repository at this point in the history

  3. example changes

    @dg-pb
    dg-pb committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9038ed5 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. serialization issues addressed

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    49b8c71 View commit details
    Browse the repository at this point in the history

  2. delete redundant references

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bc1fdbd View commit details
    Browse the repository at this point in the history

  3. simplify PyPlaceholder implementation

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3067221 View commit details
    Browse the repository at this point in the history

  4. more optimal python functools.partial

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1185510 View commit details
    Browse the repository at this point in the history

  5. placeholder arg and pre-placeholder instance conversions to positional

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    266b4fa View commit details
    Browse the repository at this point in the history

  6. unittest.mock.ANY test for Placeholder

    @dg-pb
    dg-pb committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    dd58a12 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. functools.partial.__get__

    @dg-pb
    dg-pb committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5971fbb View commit details
    Browse the repository at this point in the history

  2. Revert "functools.partial.__get__" 

    This reverts commit 5971fbb.
    @dg-pb
    dg-pb committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9033650 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into implement-119127-again

    @dg-pb
    dg-pb authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d31e5d1 View commit details
    Browse the repository at this point in the history

  4. review changes

    @dg-pb
    dg-pb committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a3d39b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. factor out repr. same to be used for partial and partialmethod

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9e4c5df View commit details
    Browse the repository at this point in the history

  2. microopt & args.count(Placeholder) can not be used as it uses __eq__

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    16f12f8 View commit details
    Browse the repository at this point in the history

  3. simplify preparation

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    82dd600 View commit details
    Browse the repository at this point in the history

  4. whatsnew + minor doc edit

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f9cb653 View commit details
    Browse the repository at this point in the history

  5. typo fixes

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d255524 View commit details
    Browse the repository at this point in the history

  6. whatsnew edit

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    404044e View commit details
    Browse the repository at this point in the history

  7. revert stylistic changes

    @dg-pb
    dg-pb committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    800217b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. factor out full __new__

    @dg-pb
    dg-pb committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    38ee450 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'main' into implement-119127-again

    @serhiy-storchaka
    serhiy-storchaka authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    11f47db View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Merge branch 'main' into implement-119127-again

    @serhiy-storchaka
    serhiy-storchaka authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    3c872bd View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. CR part 1

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    fd16189 View commit details
    Browse the repository at this point in the history

  2. CR Part 2

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a6c6ef2 View commit details
    Browse the repository at this point in the history

  3. remove ignored global var

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1c8d73e View commit details
    Browse the repository at this point in the history

  4. CR changes

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a8bd3ae View commit details
    Browse the repository at this point in the history

  5. small CR changes and doc updates

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    70e47ed View commit details
    Browse the repository at this point in the history

  6. push placeholder check to earlier place

    @dg-pb
    dg-pb committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2eacf5e View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. more appropriate test functions and better doc example

    @dg-pb
    dg-pb committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f78d8d3 View commit details
    Browse the repository at this point in the history

  2. minor fixes; message, doc polish

    @dg-pb
    dg-pb committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0a8640e View commit details
    Browse the repository at this point in the history

  3. better doc example and small test changes

    @dg-pb
    dg-pb committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6e3d282 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. assertRaisesRegex exact match

    @dg-pb
    dg-pb committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    66c305d View commit details
    Browse the repository at this point in the history

  2. doc nits

    @dg-pb
    dg-pb committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    14bf68c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add Placeholder to __all__

    @rhettinger
    rhettinger committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ee642d5 View commit details
    Browse the repository at this point in the history

  2. Update copyright span

    @rhettinger
    rhettinger committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8d6c28e View commit details
    Browse the repository at this point in the history

  3. Minor doc edits and add doctests

    @rhettinger
    rhettinger committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8744bcb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into implement-119127-again

    @rhettinger
    rhettinger authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b896470 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into implement-119127-again

    @rhettinger
    rhettinger authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4881ae6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Having the separate dict was necessary to eliminate duplicate keywords

    @rhettinger
    rhettinger committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c3ad7d9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into implement-119127-again

    @rhettinger
    rhettinger authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5e5d484 View commit details
    Browse the repository at this point in the history