Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120268: Prohibit passing None to _pydatetime.date.fromtimestamp #120269

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jun 8, 2024

Lib/test/datetimetester.py Outdated Show resolved Hide resolved
@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 8, 2024
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the change is correct. Thanks!

@pganssle pganssle merged commit 34f5ae6 into python:main Jun 8, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…timestamp`` (pythonGH-120269)

This makes the pure Python implementation consistent with the C implementation.
(cherry picked from commit 34f5ae6)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2024

GH-120282 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…timestamp`` (pythonGH-120269)

This makes the pure Python implementation consistent with the C implementation.
(cherry picked from commit 34f5ae6)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2024

GH-120283 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 8, 2024
@Eclips4 Eclips4 deleted the issue-120268 branch June 8, 2024 21:23
serhiy-storchaka pushed a commit that referenced this pull request Jun 11, 2024
…mtimestamp`` (GH-120269) (GH-120282)

This makes the pure Python implementation consistent with the C implementation.
(cherry picked from commit 34f5ae6)

Co-authored-by: Kirill Podoprigora <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Jun 11, 2024
…mtimestamp`` (GH-120269) (GH-120283)

This makes the pure Python implementation consistent with the C implementation.
(cherry picked from commit 34f5ae6)

Co-authored-by: Kirill Podoprigora <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…timestamp`` (python#120269)

This makes the pure Python implementation consistent with the C implementation.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…timestamp`` (python#120269)

This makes the pure Python implementation consistent with the C implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants