-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120268: Prohibit passing None
to _pydatetime.date.fromtimestamp
#120269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Jun 8, 2024
Eclips4
added
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
Jun 8, 2024
sobolevn
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the change is correct. Thanks!
pganssle
approved these changes
Jun 8, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2024
…timestamp`` (pythonGH-120269) This makes the pure Python implementation consistent with the C implementation. (cherry picked from commit 34f5ae6) Co-authored-by: Kirill Podoprigora <[email protected]>
GH-120282 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2024
…timestamp`` (pythonGH-120269) This makes the pure Python implementation consistent with the C implementation. (cherry picked from commit 34f5ae6) Co-authored-by: Kirill Podoprigora <[email protected]>
GH-120283 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 11, 2024
…mtimestamp`` (GH-120269) (GH-120282) This makes the pure Python implementation consistent with the C implementation. (cherry picked from commit 34f5ae6) Co-authored-by: Kirill Podoprigora <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 11, 2024
…mtimestamp`` (GH-120269) (GH-120283) This makes the pure Python implementation consistent with the C implementation. (cherry picked from commit 34f5ae6) Co-authored-by: Kirill Podoprigora <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…timestamp`` (python#120269) This makes the pure Python implementation consistent with the C implementation.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…timestamp`` (python#120269) This makes the pure Python implementation consistent with the C implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date.fromtimestamp(None)
behaves differently between_pydatetime
and_datetime
#120268