Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120541: Improve the "less" prompt in pydoc #120543

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 15, 2024

When help() is called with non-string argument, use qualname or name if available, otherwise use "{typename} object".

When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
Lib/pydoc.py Outdated Show resolved Hide resolved
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice enhancement.

@serhiy-storchaka serhiy-storchaka merged commit 31d1d72 into python:main Jun 15, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the help-prompt branch June 15, 2024 17:56
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2024
When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
(cherry picked from commit 31d1d72)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 15, 2024

GH-120562 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 15, 2024
@serhiy-storchaka
Copy link
Member Author

Thank you for your review, @AlexWaygood.

serhiy-storchaka added a commit that referenced this pull request Jun 15, 2024
…120562)

When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
(cherry picked from commit 31d1d72)

Co-authored-by: Serhiy Storchaka <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
When help() is called with non-string argument, use __qualname__ or
__name__ if available, otherwise use "{typename} object".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants