gh-119109: functool.partial vectorcall supports pto->kw & fallback to tp_call removed #120783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although comment stated that "merging keyword arguments for vector call is messy" (not exact quote), but I have found that it is fairly straight forward.
This achieves 2 goals:
partial
being stuck intp_call
after keywords are deleted even if function supportsvectorcall
.len(pto-kw) != 0
and function supportsvectorcall
.Number 1. is solved better than it was in #119125 as there are no more switching between methods and faster
vectorcall
is used whenever appropriate. Also, this does not require additional variable in class struct.Comparison of performance:
This is only initial attempt and I think the code can be made simpler. (much simpler if decide to use
_PyObject_VectorcallDictTstate
).This will need to be adjusted to #119827 so do not merge.