gh-121008: Fix idlelib.run tests #121046
Merged
gh-121008: Fix idlelib.run tests #121046
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
|
Without this change, With this change, the same command no longer hangs. |
ambv
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Fixes the issue for me on Ubuntu and macOS, both GUI builds. Tests pass with:
> /Volumes/RAMDisk/installed-main/bin/python3 -E -Wd -m test --slowest --fail-env-changed -uall test_idle test_pyrepl
Using random seed: 2738848300
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 9.16 Run 2 tests sequentially in a single process
0:00:00 load avg: 9.16 [1/2] test_idle
0:00:09 load avg: 9.14 [2/2] test_pyrepl
== Tests result: SUCCESS ==
10 slowest tests:
- test_idle: 9.3 sec
- test_pyrepl: 4.5 sec
All 2 tests OK.
Total duration: 13.9 sec
Total tests: run=740 skipped=5
Total test files: run=2/2
Result: SUCCESS
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2024
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook. (cherry picked from commit 44eafd6) Co-authored-by: Victor Stinner <[email protected]>
|
GH-121049 is a backport of this pull request to the 3.13 branch. |
|
Ok, let me merge this change and see how it goes. Thanks for the review @ambv. |
vstinner
added a commit
that referenced
this pull request
Jun 26, 2024
gh-121008: Fix idlelib.run tests (GH-121046) When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook. (cherry picked from commit 44eafd6) Co-authored-by: Victor Stinner <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.