Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121359: Run test_pyrepl in isolated mode #121414

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 5, 2024

run_repl() now pass the -I option (isolated mode) to Python if the 'env' parameter is not set.

run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
@smontanaro
Copy link
Contributor

This solves the test_exposed_globals_in_repl failure. The test_not_wiping_history_file failure still remains (as expected, I suppose).

@smontanaro
Copy link
Contributor

I don't see a "backport" label, but note that this needs to go to 3.13 as well.

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 5, 2024
@vstinner vstinner merged commit 6239d41 into python:main Jul 5, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_pyrepl_isolated branch July 5, 2024 20:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2024
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
(cherry picked from commit 6239d41)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 5, 2024

GH-121417 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2024
@vstinner
Copy link
Member Author

vstinner commented Jul 5, 2024

This solves the test_exposed_globals_in_repl failure.

Good, thanks for testing!

The test_not_wiping_history_file failure still remains (as expected, I suppose).

As expected, it's unrelated.

I don't see a "backport" label, but note that this needs to go to 3.13 as well.

Right. I backported the change to 3.13.

vstinner added a commit that referenced this pull request Jul 5, 2024
gh-121359: Run test_pyrepl in isolated mode (GH-121414)

run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
(cherry picked from commit 6239d41)

Co-authored-by: Victor Stinner <[email protected]>
@skirpichev
Copy link
Member

The test_not_wiping_history_file failure still remains (as expected, I suppose).

This is fixed by #121422.

@vstinner, I think this pr address also #121271. At least, I can't reproduce that failure in the current main.

@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2024

@vstinner, I think this pr address also #121271. At least, I can't reproduce that failure in the current main.

Right, I closed the issue.

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
run_repl() now pass the -I option (isolated mode) to Python if the
'env' parameter is not set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants