Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121453: Update the Doc/templates/download.html download files size estimates and support download .texi format. #121454

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Jul 7, 2024

Python 3.8 added support for texinfo format #14606 , but not added link in https://github.com/python/cpython/blob/main/Doc/tools/templates/download.html

And need update the doc download files size estimates. The latest update was in Python 2.7

According https://www.python.org/ftp/python/doc/3.12.4/


📚 Documentation preview 📚: https://cpython-previews--121454.org.readthedocs.build/en/121454/download.html

@Wulian233
Copy link
Contributor Author

@hugovk do you have some time to give this a review? Thanks!

Doc/tools/templates/download.html Outdated Show resolved Hide resolved
Doc/tools/templates/download.html Outdated Show resolved Hide resolved
@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
@hugovk hugovk merged commit 3761117 into python:main Jul 17, 2024
24 checks passed
@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
…les size estimates and support download `.texi` format. (pythonGH-121454)

(cherry picked from commit 3761117)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
…les size estimates and support download `.texi` format. (pythonGH-121454)

(cherry picked from commit 3761117)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 17, 2024

GH-121890 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 17, 2024

GH-121891 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 17, 2024
@hugovk
Copy link
Member

hugovk commented Jul 17, 2024

Thanks! I don't think this is something we need to update very regularly (it does say "circa"), but it's okay to do it once in a while after big changes.

hugovk added a commit that referenced this pull request Jul 17, 2024
…iles size estimates and support download `.texi` format. (GH-121454) (#121891)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Jul 17, 2024
…iles size estimates and support download `.texi` format. (GH-121454) (#121890)

Co-authored-by: Wulian233 <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Wulian233 Wulian233 deleted the doc-size branch July 17, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants