-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-65453: Docs - clarify AttributeError behaviour on PropertyMock #121666
Merged
encukou
merged 2 commits into
python:main
from
ziima:gh-65453-docs-property-mock-attr-error
Jul 18, 2024
Merged
gh-65453: Docs - clarify AttributeError behaviour on PropertyMock #121666
encukou
merged 2 commits into
python:main
from
ziima:gh-65453-docs-property-mock-attr-error
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed at EuroPython 24 sprints.
bedevere-app
bot
added
docs
Documentation in the Doc dir
skip news
awaiting review
labels
Jul 13, 2024
encukou
reviewed
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
There are a few things to improve, mostly related to Sphinx and restructured text.
(I didn't test the suggestion.)
Co-authored-by: Petr Viktorin <[email protected]>
encukou
added
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
Jul 18, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2024
…ck (pythonGH-121666) Fixed at EuroPython 24 sprints. (cherry picked from commit 94e6644) Co-authored-by: Vlastimil Zíma <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2024
…ck (pythonGH-121666) Fixed at EuroPython 24 sprints. (cherry picked from commit 94e6644) Co-authored-by: Vlastimil Zíma <[email protected]>
GH-121968 is a backport of this pull request to the 3.13 branch. |
GH-121969 is a backport of this pull request to the 3.12 branch. |
encukou
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ock (GH-121666) (GH-121968) Fixed at EuroPython 24 sprints. (cherry picked from commit 94e6644) Co-authored-by: Vlastimil Zíma <[email protected]>
encukou
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ock (GH-121666) (GH-121969) Fixed at EuroPython 24 sprints. (cherry picked from commit 94e6644) Co-authored-by: Vlastimil Zíma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed at EuroPython 24 sprints.
📚 Documentation preview 📚: https://cpython-previews--121666.org.readthedocs.build/