Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-65453: Docs - clarify AttributeError behaviour on PropertyMock #121666

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ziima
Copy link
Contributor

@ziima ziima commented Jul 13, 2024

Copy link

cpython-cla-bot bot commented Jul 13, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
There are a few things to improve, mostly related to Sphinx and restructured text.

(I didn't test the suggestion.)

Doc/library/unittest.mock.rst Outdated Show resolved Hide resolved
@encukou encukou added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@encukou encukou merged commit 94e6644 into python:main Jul 18, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @ziima for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121968 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121969 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 18, 2024
encukou pushed a commit that referenced this pull request Jul 19, 2024
…ock (GH-121666) (GH-121968)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <[email protected]>
encukou pushed a commit that referenced this pull request Jul 19, 2024
…ock (GH-121666) (GH-121969)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants