Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain #121672

Merged
merged 4 commits into from
Jul 15, 2024
Merged

gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain #121672

merged 4 commits into from
Jul 15, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Jul 13, 2024
@skirpichev

This comment was marked as outdated.

Sign in to view
@skirpichev skirpichev force-pushed the use-clean-env-in-test_pyrepl-121359 branch from bd2787b to 3cc746c Compare July 13, 2024 10:00
@skirpichev skirpichev mentioned this pull request Jul 13, 2024
Merged
@skirpichev skirpichev changed the title gh-121359: make clean environment (not PYTHON* vars) for test_pyrepl.py gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.py Jul 13, 2024
@ambv ambv added the skip news label Jul 13, 2024
pablogsal
pablogsal previously requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please, check my comment for a suggestion on how to handle this correctly

@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@skirpichev skirpichev changed the title gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.py gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain Jul 13, 2024
@skirpichev
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pablogsal July 13, 2024 15:47
@vstinner vstinner mentioned this pull request Jul 13, 2024
Merged
@smontanaro
Copy link
Contributor

test_pyrepl passes after applying the PR to an up-to-date main branch.

@ambv ambv dismissed pablogsal’s stale review July 15, 2024 19:19

This fix is for unit tests that don't spawn a subprocess

@ambv ambv added the needs backport to 3.13 bugs and security fixes label Jul 15, 2024
@ambv ambv merged commit fd085a4 into python:main Jul 15, 2024
33 of 34 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2024
@skirpichev @ambv @miss-islington
pythongh-121359: make clean environment (no PYTHON* vars) for test_py…
2784c19 
…repl.TestMain (pythonGH-121672)

(cherry picked from commit fd085a4)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 15, 2024

GH-121810 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 15, 2024
ambv added a commit that referenced this pull request Jul 15, 2024
@miss-islington @skirpichev @ambv
[3.13] gh-121359: make clean environment (no PYTHON* vars) for test_p…
2ee2bfe 
…yrepl.TestMain (GH-121672) (GH-121810)

(cherry picked from commit fd085a4)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@skirpichev skirpichev deleted the use-clean-env-in-test_pyrepl-121359 branch July 16, 2024 00:55
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@skirpichev @ambv @estyxx
pythongh-121359: make clean environment (no PYTHON* vars) for test_py…
42747d1 
…repl.TestMain (pythonGH-121672)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@ambv ambv ambv left review comments

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skirpichev @smontanaro @ambv @vstinner @pablogsal