gh-121546: Disable contextvar caching on free-threading build #121740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
I think this is the right approach for now, especially for 3.13. LGTM, with two comments:
- There's an unused variable warning (see comment below)
- Consider adding the
#ifndefguards instruct _pycontextvarobjectaround the cache fields as well to make it more clear that they are not used in the free-threaded build.
colesbury
approved these changes
Jul 15, 2024
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2024
…ythonGH-121740) (cherry picked from commit e904300) Co-authored-by: Ken Jin <[email protected]>
|
GH-121808 is a backport of this pull request to the 3.13 branch. |
colesbury
pushed a commit
that referenced
this pull request
Jul 15, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by running the repros in the issue on a TSAN build for 2-3 minutes each. No races reported.