Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-57141: Make shallow argument to filecmp.dircmp keyword-only (GH-121767) #121777

Merged
merged 1 commit into from
Jul 14, 2024
Merged

[3.13] gh-57141: Make shallow argument to filecmp.dircmp keyword-only (GH-121767) #121777

merged 1 commit into from
Jul 14, 2024

Commits on Jul 14, 2024

  1. pythongh-57141: Make shallow argument to filecmp.dircmp keyword-only (p… 

    …ythonGH-121767)

It is our general practice to make new optional parameters keyword-only,
even if the existing parameters are all positional-or-keyword. Passing
this parameter as positional would look confusing and could be error-prone
if additional parameters are added in the future.
(cherry picked from commit 50eec50)

Co-authored-by: Jelle Zijlstra <[email protected]>
    @JelleZijlstra @miss-islington
    JelleZijlstra authored and miss-islington committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f9a5167 View commit details
    Browse the repository at this point in the history