-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-121790: Fix interactive console initialization #121793
Conversation
a33259e
to
9a24df1
Compare
try: | ||
from _pyrepl.main import CAN_USE_PYREPL | ||
except ImportError: | ||
CAN_USE_PYREPL = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplify this here because in the current state of the code there is no reason for this import to ever fail.
def test_asyncio_repl_no_tty_fails(self): | ||
assert assert_python_failure("-m", "asyncio") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test used to be test_asyncio_repl_is_ok
before we broke it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows failure in the PYTHONSTARTUP test is a bit peculiar. It's actually an exception in asyncio proper:
It's definitely related though, so I'm investigating. |
) (cherry picked from commit e5c7216) Co-authored-by: Milan Oberkirch <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
GH-121822 is a backport of this pull request to the 3.13 branch. |
…H-121822) (cherry picked from commit e5c7216) Co-authored-by: Milan Oberkirch <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
See #121790 for details.
python3.13 -m asyncio
immediately fails withTypeError
#121790