Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-120371: Add WASI SDK 22 support #121870

Merged
merged 2 commits into from
Jul 16, 2024
Merged

GH-120371: Add WASI SDK 22 support #121870

merged 2 commits into from
Jul 16, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Jul 16, 2024 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon added the needs backport to 3.13 bugs and security fixes label Jul 16, 2024
@brettcannon brettcannon self-assigned this Jul 16, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 16, 2024
Closed
@brettcannon brettcannon enabled auto-merge (squash) July 16, 2024 19:32
@brettcannon brettcannon enabled auto-merge (squash) July 16, 2024 19:39
@brettcannon brettcannon merged commit f589f26 into python:main Jul 16, 2024
43 checks passed
@brettcannon brettcannon deleted the wasi-sdk-22 branch July 16, 2024 20:00
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
@brettcannon @miss-islington
pythonGH-120371: Add WASI SDK 22 support (pythonGH-121870)
84918c8 
Required disabling stub functions now provided by wasi-libc.
(cherry picked from commit f589f26)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2024

GH-121873 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 16, 2024
brettcannon added a commit that referenced this pull request Jul 16, 2024
@miss-islington @brettcannon
[3.13] GH-120371: Add WASI SDK 22 support (GH-121870) (GH-121873)
2e34591 
GH-120371: Add WASI SDK 22 support (GH-121870)

Required disabling stub functions now provided by wasi-libc.
(cherry picked from commit f589f26)

Co-authored-by: Brett Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @ezio-melotti