gh-102511: Change the os.path.splitroot param name from path back to p
#124097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
approved these changes
Sep 15, 2024
|
Thanks, I didn't notice this. I was too focused on the difficult aspects of the PR. |
|
Sorry, @sobolevn and @zooba, I could not cleanly backport this to |
|
Backport should wait for 3.13.1 anyway, so we'll rebase it then. |
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
|
GH-124919 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Oct 3, 2024
…m `path` back to `p` (pythonGH-124097) (cherry picked from commit 3b6bfa7) Co-authored-by: sobolevn <[email protected]>
|
I opened the backport PR just so this doesn't get lost, the conflict was in clinic output only. |
JelleZijlstra
added a commit
that referenced
this pull request
Oct 8, 2024
…h` back to `p` (GH-124097) (#124919) (cherry picked from commit 3b6bfa7) Co-authored-by: sobolevn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #118089
CC @nineteendo
Now it is in sync with the Python version here:
cpython/Lib/posixpath.py
Line 141 in 401fff7
cpython/Lib/ntpath.py
Line 172 in 401fff7