Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123153: Fix PGO builds with free-threading on Windows #125607

Merged
merged 2 commits into from
Oct 17, 2024
Merged

gh-123153: Fix PGO builds with free-threading on Windows #125607

merged 2 commits into from
Oct 17, 2024

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Oct 16, 2024 •
edited by bedevere-app bot
Loading

This applies the same workaround we are applying to JIT builds to free-threaded builds.

@bedevere-app bedevere-app bot mentioned this pull request Oct 16, 2024
Closed
@mdboom mdboom requested a review from colesbury October 16, 2024 18:38
colesbury
colesbury reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

Python/ceval.c Outdated Show resolved Hide resolved
@mdboom mdboom merged commit 37986e8 into python:main Oct 17, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
OS-windows performance Performance or resource usage skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @colesbury