Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-125837: Split LOAD_CONST into three. #125972

Merged
merged 34 commits into from
Oct 29, 2024
Merged

GH-125837: Split LOAD_CONST into three. #125972

merged 34 commits into from
Oct 29, 2024

Commits on Oct 22, 2024

  1. Replace RETURN_VLAUE/RETURN_CONST with RETURN_VALUE_FUNC/RETURN_VALUE… 

    …_GEN
    @markshannon
    markshannon committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2a61cfc View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add LOAD_CONST_IMMORTAL

    @markshannon
    markshannon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    42a526c View commit details
    Browse the repository at this point in the history

  2. Fix up all the tests apart from test_dis

    @markshannon
    markshannon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2a3b1e2 View commit details
    Browse the repository at this point in the history

  3. Update optimizer

    @markshannon
    markshannon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    031f320 View commit details
    Browse the repository at this point in the history

  4. Fix up test_dis

    @markshannon
    markshannon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    cb5252b View commit details
    Browse the repository at this point in the history

  5. Fix up a couple of comments

    @markshannon
    markshannon committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    892edbc View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Tomas R. <[email protected]>
    @markshannon @tomasr8
    markshannon and tomasr8 authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5ce99ca View commit details
    Browse the repository at this point in the history

  2. Clarify comment

    @markshannon
    markshannon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    325c5fe View commit details
    Browse the repository at this point in the history

  3. Remove unused function

    @markshannon
    markshannon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6149153 View commit details
    Browse the repository at this point in the history

  4. Update test

    @markshannon
    markshannon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    59a554a View commit details
    Browse the repository at this point in the history

  5. Update dis docs

    @markshannon
    markshannon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bcb4e65 View commit details
    Browse the repository at this point in the history

  6. Remove link to remove instruction

    @markshannon
    markshannon committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f3383e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Restore RETURN_VALUE

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    68e97ba View commit details
    Browse the repository at this point in the history

  2. Add LOAD_INT instruction

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0b8a5ad View commit details
    Browse the repository at this point in the history

  3. Fix up dis and some tests

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1bfdd70 View commit details
    Browse the repository at this point in the history

  4. Fix up test dis

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f934559 View commit details
    Browse the repository at this point in the history

  5. Address review comments

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f135b69 View commit details
    Browse the repository at this point in the history

  6. Fix __annotate__ docstring

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8f2a781 View commit details
    Browse the repository at this point in the history

  7. Teach optimizer about LOAD_INT

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    97c6cdc View commit details
    Browse the repository at this point in the history

  8. Remove remnants of earlier PR

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    eefcbdf View commit details
    Browse the repository at this point in the history

  9. Remove last remnant of earlier PR

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    58dab8e View commit details
    Browse the repository at this point in the history

  10. Remove the definitely last remnant of earlier PR

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    81e4dd6 View commit details
    Browse the repository at this point in the history

  11. Document LOAD_INT and add news

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    050fc1e View commit details
    Browse the repository at this point in the history

  12. Revert unnecessary name changes

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    46055c1 View commit details
    Browse the repository at this point in the history

  13. Make functions static again to avoid warning

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    79305d2 View commit details
    Browse the repository at this point in the history

  14. implement review suggestion

    @markshannon
    markshannon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7e4b2a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Address review comments

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    57e891e View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    207e35e View commit details
    Browse the repository at this point in the history

  3. Remove extra argument

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7c88f69 View commit details
    Browse the repository at this point in the history

  4. Rename LOAD_INT to LOAD_SMALL_INT

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    9d4e575 View commit details
    Browse the repository at this point in the history

  5. Regenerate test file

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ae11453 View commit details
    Browse the repository at this point in the history

  6. Fix test_dis

    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3a50437 View commit details
    Browse the repository at this point in the history

  7. Don't mark LOAD_SMALL_INT as having a constant, as it doesn't load fr… 

    …om code.co_consts
    @markshannon
    markshannon committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    47927cf View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Add back int to test

    @markshannon
    markshannon committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3caac1a View commit details
    Browse the repository at this point in the history