Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126040: add versioning to XML elements to protect against evil mutations #126041

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-126040: add versioning to XML elements to protect against evil mutations #126041

wants to merge 5 commits into from

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Oct 27, 2024 •
edited
Loading

For now, I just want to add the attributes and update them accordingly. I'll fix each bad case in a separate PR.

@bedevere-app bedevere-app bot mentioned this pull request Oct 27, 2024
Open
@picnixz picnixz added skip news extension-modules C modules in the Modules dir topic-XML and removed awaiting review labels Oct 27, 2024
@picnixz picnixz mentioned this pull request Oct 28, 2024
Open
sobolevn
sobolevn reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, I was thinking about something like that :)

@picnixz

This comment was marked as resolved.

Sign in to view
@picnixz picnixz mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir skip news topic-XML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @sobolevn