Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126433: Fix compiler warnings on 32-bit Windows #126444

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 5, 2024

@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2024

I didn't fix these two warnings on purpose, I will fix them separately:

C:\victor\python\main\Modules_hacl\Lib_Memzero0.c(39,27): warning C4244: 'function': conversion from 'uint64_t' to 'SIZE_T', possible loss of data [C:\victor\python\main\PCbuild\pythoncore.vcxproj]
C:\victor\python\main\Modules_interpchannelsmodule.c(2096,30): warning C4244: '=': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data [C:\victor\python\main\PCbuild\pythoncore.vcxproj]

@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2024

cc @sobolevn

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vstinner vstinner merged commit 0b67ce9 into python:main Nov 5, 2024
45 checks passed
@vstinner vstinner deleted the fix_win_warns branch November 5, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants