GH-123877: default to wasm32-wasip1 instead of wasm32-wasi to be more specific
#126552
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be more specific
brettcannon
requested review from
freakboy3742,
erlend-aasland and
corona10
as code owners
erlend-aasland
approved these changes
Nov 7, 2024
Co-authored-by: Erlend E. Aasland <[email protected]>
…into 123877-wasip1
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @brettcannon, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually wasm32-wasi will represent WASI 1.0, and so it's currently deprecated for that eventual transition. wasm32-wasip1 is also more specific to what version of WASI that is currently supported.
wasm32-wasip1as the default WASI target triple #123877