[3.8] bpo-37221: Add PyCode_NewWithPosOnlyArgs to be used internally and set PyCode_New as a compatibility wrapper (GH-13959) #14505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t PyCode_New as a compatibility wrapper (pythonGH-13959) Add PyCode_NewEx to be used internally and set PyCode_New as a compatibility wrapper (cherry picked from commit 4a2edc3) Co-authored-by: Pablo Galindo <[email protected]>
|
cc @ambv |
|
@pablogsal and @encukou: Status check is done, and it's a success ✅ . |
2 similar comments
|
@pablogsal and @encukou: Status check is done, and it's a success ✅ . |
|
@pablogsal and @encukou: Status check is done, and it's a success ✅ . |
|
@ambv: Please replace |
|
Does this PR restore the signature of |
Ark-kun
added a commit
to Ark-kun/pipelines
that referenced
this pull request
Feb 19, 2020
Fixes the follwoing error: "TypeError: code() takes at least 14 arguments (13 given)". The cause of the issue is a breaking change in CodeType constructor in Python 3.8. https://bugs.python.org/issue37221 This should have been fixed by python/cpython#13959 and python/cpython#14505, but the code still fails.
No. Check my comment in the other PR you asked about for an explanation: |
k8s-ci-robot
pushed a commit
to kubeflow/pipelines
that referenced
this pull request
Feb 24, 2020
* SDK - Fix SDK on Python 3.8 Fixes the follwoing error: "TypeError: code() takes at least 14 arguments (13 given)". The cause of the issue is a breaking change in CodeType constructor in Python 3.8. https://bugs.python.org/issue37221 This should have been fixed by python/cpython#13959 and python/cpython#14505, but the code still fails. * Simplified the replace call
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* SDK - Fix SDK on Python 3.8 Fixes the follwoing error: "TypeError: code() takes at least 14 arguments (13 given)". The cause of the issue is a breaking change in CodeType constructor in Python 3.8. https://bugs.python.org/issue37221 This should have been fixed by python/cpython#13959 and python/cpython#14505, but the code still fails. * Simplified the replace call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PyCode_NewEx to be used internally and set PyCode_New as a compatibility wrapper
(cherry picked from commit 4a2edc3)
Co-authored-by: Pablo Galindo [email protected]
https://bugs.python.org/issue37221