Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36876: Add a tool that identifies unsupported global C variables. #15877

Merged
merged 118 commits into from
Sep 11, 2019
Merged

bpo-36876: Add a tool that identifies unsupported global C variables. #15877

merged 118 commits into from
Sep 11, 2019

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 10, 2019 •
edited
Loading

This PR does 2 things:

  • make the globals checker tool more robust and maintainable
  • add a test that invokes the checker and fails if any unsupported globals have been added

For now the test is marked as a known failure. I'll be working to fix all of unsupported globals, at which point I'll unmark the test.

Note that this PR adds code to Tools/c-analyzer or adds new tests. The only existing code I touch is where I factor out an existing testing helper from tests for another tool.

https://bugs.python.org/issue36876

@vstinner
Copy link
Member

115 commits, 51 files changes, and wow, that's a huge PR.

@vstinner
Copy link
Member

vstinner commented Sep 10, 2019 •
edited by bedevere-bot
Loading

" bpo-36876: Make sure no new globals get added."

So far, the C API don't provide any solution for function "static PyObject *local_global_var = ...;" :-)

@ericsnowcurrently ericsnowcurrently changed the title bpo-36876: Make sure no new globals get added. bpo-36876: Add a tool that identifies unsupported global C variables. Sep 11, 2019
@ericsnowcurrently
Copy link
Member Author

Yeah, it's a lot, but it's all under Tools/. :) Also, I've updated the title to be more clear.

@ericsnowcurrently
Copy link
Member Author

FYI, all the failures are strictly with patchcheck, which is complaining about whitespace in some files. I cannot reproduce that locally.

@ericsnowcurrently ericsnowcurrently merged commit ee536b2 into python:master Sep 11, 2019
@ericsnowcurrently ericsnowcurrently deleted the globals-checker branch September 11, 2019 18:49
@bedevere-bot
Copy link

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently
Distinguish "static" vars in output.
48b2460
@ericsnowcurrently
Special-case variables named "id".
c0a631b
@ericsnowcurrently
Fix a test.
3989a69
@ericsnowcurrently
Print totals.
8118454
@ericsnowcurrently
Fail if we couldn't find any of the symbols.
cae5e3a
@ericsnowcurrently
Factor out _check_results().
87ebe87
@ericsnowcurrently
Fill in gaps in known.tsv.
91e4fb1
@ericsnowcurrently
Mark _Py_IDENTIFIER() as unsupported.
21c4175
@ericsnowcurrently
Keep "static" in output.
a245849
@ericsnowcurrently
Fix a typo in __main__.py.
1437d56
@ericsnowcurrently
Honor provided dirnames.
7feea9d
@ericsnowcurrently
Fix tests.
ae23801
@ericsnowcurrently
Deal with default dirnames properly.
26aaccb
@ericsnowcurrently
Supporting hiding objects in output.
4aaad5f
@ericsnowcurrently
Recognize more object types.
3d36cfc
@ericsnowcurrently
Ignore known non-statics.
b7420d5
@ericsnowcurrently
Always support "static const" (non-object) variables.
da151a7
@ericsnowcurrently
"statics" -> "globals".
6470eb1
@ericsnowcurrently
Maybe limit the variables in known.tsv.
1233cf9
@ericsnowcurrently
Generate the ignored.tsv file.
fc6c97e
@ericsnowcurrently
Ignore variables with benign races.
6f8a223
@ericsnowcurrently
Mark more variables as PyObject.
6c1db44
@ericsnowcurrently
Consider private, non-static globals.
5888d48
@ericsnowcurrently
Update ignored global variables.
cdeb1d9
@ericsnowcurrently
Skip the check where "nm" isn't available.
569c57e
@ericsnowcurrently
Ignore REPL-related variables.
7b0745f
@ericsnowcurrently
Fix whitespace.
b5dd31b
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@ericsnowcurrently @DinoV
bpo-36876: Add a tool that identifies unsupported global C variables. (…
7654be1 
…python#15877)
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericsnowcurrently @vstinner @bedevere-bot @the-knights-who-say-ni