Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-25866: Minor cleanups to "sequence" in docs #17177

Merged
merged 3 commits into from
Nov 17, 2019
Merged

bpo-25866: Minor cleanups to "sequence" in docs #17177

merged 3 commits into from
Nov 17, 2019

Conversation

alclarks
Copy link
Contributor

@alclarks alclarks commented Nov 15, 2019 •
edited by bedevere-bot
Loading

Hi, this is a pull request for my patch for BPO issue 25866.

https://bugs.python.org/issue25866

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 15, 2019
@brandtbucher brandtbucher mentioned this pull request Nov 15, 2019
Closed
@brandtbucher
Copy link
Member

Thanks @alclarks! I've recommended that #17175 be closed in favor of this PR.

brandtbucher
brandtbucher requested changes Nov 15, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of minor cleanup, but otherwise this looks good:

Doc/reference/datamodel.rst Outdated Show resolved Hide resolved
Doc/reference/datamodel.rst Outdated Show resolved Hide resolved
alclarks and others added 2 commits November 15, 2019 20:51
@alclarks @brandtbucher
Update Doc/reference/datamodel.rst
c874858 
Change "variable" for "attribute"

Co-Authored-By: Brandt Bucher <[email protected]>
@alclarks @brandtbucher
Update Doc/reference/datamodel.rst
1f1559c 
Tweak for readability

Co-Authored-By: Brandt Bucher <[email protected]>
@alclarks
Copy link
Contributor Author

Thanks for the review @brandtbucher, does this one require a news entry?

@brandtbucher
Copy link
Member

Do you think so? If not, I can add the label.

@alclarks
Copy link
Contributor Author

Because it's entirely documentation and not documenting any new feature I don't think the news would be useful - but I'm happy to add one if you think it's a big enough change to warrant some news :)

@brandtbucher
Copy link
Member

Agreed... I think your judgement is correct here.

@brandtbucher
Copy link
Member

CC @rhettinger

@rhettinger rhettinger merged commit 4544e78 into python:master Nov 17, 2019
@miss-islington
Copy link
Contributor

Thanks @alclarks for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2019
@alclarks @miss-islington
bpo-25866: Minor cleanups to "sequence" in docs (pythonGH-17177)
80f7640 
(cherry picked from commit 4544e78)

Co-authored-by: alclarks <[email protected]>
@bedevere-bot
Copy link

GH-17208 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Thanks @alclarks for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17209 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2019
@alclarks @miss-islington
bpo-25866: Minor cleanups to "sequence" in docs (pythonGH-17177)
87c1694 
(cherry picked from commit 4544e78)

Co-authored-by: alclarks <[email protected]>
rhettinger pushed a commit that referenced this pull request Nov 17, 2019
@miss-islington @alclarks @rhettinger
bpo-25866: Minor cleanups to "sequence" in docs (GH-17177) (GH-17209)
72321c7 
(cherry picked from commit 4544e78)

Co-authored-by: alclarks <[email protected]>
rhettinger pushed a commit that referenced this pull request Nov 17, 2019
@miss-islington @alclarks @rhettinger
bpo-25866: Minor cleanups to "sequence" in docs (GH-17177) (GH-17208)
20a4f6c 
(cherry picked from commit 4544e78)

Co-authored-by: alclarks <[email protected]>
@brandtbucher
Copy link
Member

Congrats on your first CPython contribution @alclarks! 🍾

Looking forward to seeing more from you in the future.

@alclarks
Copy link
Contributor Author

Thanks @brandtbucher and @rhettinger for the review and merge!

@alclarks alclarks deleted the fix-issue-25866 branch November 18, 2019 10:21
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@alclarks
bpo-25866: Minor cleanups to "sequence" in docs (pythonGH-17177)
f48c784
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@alclarks @shihai1991
bpo-25866: Minor cleanups to "sequence" in docs (pythonGH-17177)
e417456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alclarks @brandtbucher @miss-islington @bedevere-bot @rhettinger @the-knights-who-say-ni