Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39121: write gzip header OS information #17682

Closed
wants to merge 1 commit into from

Conversation

wungad
Copy link

@wungad wungad commented Dec 23, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@wungad

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Misc/ACKS Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Lib/gzip.py Outdated Show resolved Hide resolved
Copy link
Author

@wungad wungad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes implemented.

Lib/gzip.py Outdated Show resolved Hide resolved
@csabella csabella requested a review from corona10 May 28, 2020 23:22
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wungad

Sorry for the delayed feedback.
Can you rebase your PR?
I will merge it after conflicting is resolved.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka
Copy link
Member

Sorry, but I do not think we need this feature. There is no any use case. This PR just makes the code more complex without necessity.

@wungad wungad closed this May 29, 2020
@wungad wungad deleted the write-gzip-os-field branch May 29, 2020 22:07
@wungad wungad mannequin mentioned this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants