Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44136: pathlib: merge _Flavour.is_reserved() into PurePath.is_reserved() #30321

Closed
wants to merge 3 commits into from
Closed

bpo-44136: pathlib: merge _Flavour.is_reserved() into PurePath.is_reserved() #30321

wants to merge 3 commits into from

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jan 1, 2022 •
edited by bedevere-bot
Loading

Removes a bit more indirection.

https://bugs.python.org/issue44136

@barneygale
bpo-44136: pathlib: merge _Flavour.is_reserved() into `PurePath.is_…
feae50c 
…reserved()`

Removes a bit more indirection.
arhadthedev
arhadthedev reviewed Jan 1, 2022
View reviewed changes
Lib/pathlib.py Outdated Show resolved Hide resolved
@barneygale @arhadthedev
Update Lib/pathlib.py
a2baccf 
Co-authored-by: Oleg Iarygin <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 1, 2022
@barneygale barneygale mentioned this pull request Feb 21, 2022
Closed
@brettcannon brettcannon self-requested a review February 22, 2022 23:33
MaxwellDupre
MaxwellDupre approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@barneygale
Copy link
Contributor Author

Closing per the rationale in #30320.

@barneygale barneygale closed this Mar 4, 2022
@barneygale barneygale mannequin mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees
No one assigned
Labels
awaiting core review skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barneygale @arhadthedev @MaxwellDupre @brettcannon @the-knights-who-say-ni @bedevere-bot