-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34526:[doc] Add description and examples of multiple arguments for Path.relative_to #31368
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
*other*. If it's impossible, ValueError is raised:: | ||
Return the relative path to another path identified by *other*, each | ||
element of *other* can be either a string representing a path segment, | ||
or another path object implementing the :class:`PurePath`(or a subclass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. You missed the definition of class PurePath
in the context, it could be changed from :class:PurePath
to the class PurePath
.
@barneygale would you be able to review this PR? |
I've left a comment on the #78707. I don't think |
In #94469 we deprecated passing multiple positional arguments to |
the docs for Path.relative_to is a bit confusing why other is a star-args, especially as no example actually passes more than one argument to relative_to
https://bugs.python.org/issue34526