-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90997: Show cached inline values in dis
output
#92360
Conversation
Looks good, but it should have at least one test. |
LGTM |
This PR is failing on the buildbots: https://buildbot.python.org/all/#/builders/244/builds/2311/steps/5/logs/stdio Please, prepare a fix ASAP or I would need to revert it :( |
@brandtbucher @markshannon can you take a look? |
Looking at it now. The s390x failures suggest that this may be due to endianness. My initial hunch is that this test uncovered a bug in how we're reading and writing caches (which should be in native byte order). |
The test seems to only be failing on big-endian architectures when the caches are actually populated with non-zero values. The symptom looks like messed-up parsing of nearby instructions (in this case, a |
New theory: I think |
This adds the actual values stored in
CACHE
entries to the "argrepr" field ofdis
output whenshow_caches=True
.Example:
@pablogsal, since this aids in debugging our new adaptive/specialized instructions and inline caches, I'd prefer to get this into 3.11 if possible. If you agree, please feel free to merge while I'm sleeping or whatever.