Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92434: Silence a compiler warning in _xxsubinterpretersmodule.c for 32bit version #93091

Merged
merged 1 commit into from
May 25, 2022
Merged

gh-92434: Silence a compiler warning in _xxsubinterpretersmodule.c for 32bit version #93091

merged 1 commit into from
May 25, 2022

Conversation

neonene
Copy link
Contributor

@neonene neonene commented May 23, 2022 •
edited
Loading

Currently, 32bit version of channel_list_all() gets a possible loss of data warning on MSVC.

#92434

corona10
corona10 approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since PyObject *ids = PyList_New((Py_ssize_t)count); is already casted,
type casting for i will not be a problem.

lgtm

@corona10 corona10 merged commit ac1dcb8 into python:main May 25, 2022
@neonene
Copy link
Contributor Author

neonene commented May 25, 2022

Thanks!

@neonene neonene deleted the xxwarn branch May 25, 2022 03:28
@neonene neonene mentioned this pull request May 26, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 10, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
skip news topic-subinterpreters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neonene @corona10 @AA-Turner @erlend-aasland @bedevere-bot