-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90300: Reformat the Python CLI help output #93415
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f854018
gh-90300: Reformat the Python CLI help output
serhiy-storchaka 7593852
Merge branch 'main' into reformat-help
serhiy-storchaka 1758d0a
Reduce the imdemtation of the bullet list.
serhiy-storchaka 0b0b371
Double spaces between sentences.
serhiy-storchaka 9fa1efc
Increase indentation for envvars.
serhiy-storchaka b0b7d97
Merge branch 'main' into reformat-help
serhiy-storchaka 5879868
Merge branch 'main' into reformat-help
serhiy-storchaka fada897
Merge branch 'main' into reformat-help
serhiy-storchaka ffeec35
Merge branch 'main' into reformat-help
serhiy-storchaka 64a831c
Merge branch 'main' into reformat-help
serhiy-storchaka e93da84
Merge branch 'main' into reformat-help
serhiy-storchaka 8c4fede
Fix max line length.
serhiy-storchaka a3455ac
Fix the case of the first letter.
serhiy-storchaka 72dd7bf
Add few empty lines.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous spacing was following the style of spacing for short options (see lines just above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was not. All colons were at the same column, except for long option
--check-hash-based-pycs
, in which case the colon was in the first available column. And the same pattern was used for earlier environment variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it was my intent when I added them! Maybe you disagree on the result 🙂
When I say «following», I meant that all short options have colons at the same column, check-hash-based-pycs is special and uses a new line (with the help text aligned to the help texts for short options), and this new group of long options has colons at the same column (but not the same at the short options, that doesn’t work).