gh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False #99825
Conversation
geryogam
commented
Nov 27, 2022
•
geryogam
commented
- Issue: Document sqlite3.connect() as implicitly opening transactions in the new PEP-249 manual commit mode #99824
…new PEP-249 manual commit mode
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…new PEP-249 manual commit mode
… in the new PEP-249 manual commit mode" This reverts commit 86b8244.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
There was a problem hiding this comment.
IMO, after taking some time to carefully consider both the current discussion on the issue and practical implementation here, my current view from a non-expert reader perspective is that it should in fact be mentioned in the autocommit-mode transaction control explanation with the other behavior details, and possibly elided from the autocommit parameter to connect, based on the following rationale:
- It would be quite concise to mention it there (only adding a few words), whereas it would be a whole sentence in what should be a much more austere reference, particularly one that is otherwise heavily abridged with almost all the details explained elsewhere
- Likewise, to me it feels like a better fit with the existing text/phrasing there, requiring only adding one more item in a prose list of places transactions are implicitly opened, as opposed to adding a sentence that seems somewhat out of place with the rest of the paragraph's content
- It seems to be of more use to readers as a part of a holistic explanation of the module's PEP 249-compliant mode of transaction behavior, as opposed to an isolated mention which seems less useful or potentially even confusing away from the explanation of the rest of the behavior.
- It also highlights a particular contrast when versus the legacy behavior that explanation implicitly contrasts it with, which it doesn't really do here on its own
erlend-aasland
changed the title
|
Thanks for the review! |
|
Thanks, all. While no longer directly related to the topic of this PR, IMO it's still worth adding the one-line summaries to the two parameter descriptions, as the primary rationale for them is independent of the added sentence (and for the same reasons we agreed on doing the same for
@erlend-aasland if you agree, I can open a new PR to add those. |
Please do. |
|
Thanks, opened as PR #99917 |
* main: (112 commits) pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895) pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613) Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917) pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916) pythongh-89189: More compact range iterator (pythonGH-27986) bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491) pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906) pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850) pythongh-99845: Use size_t type in __sizeof__() methods (python#99846) pythonGH-99877) Fix typo in exception message in `multiprocessing.pool` (python#99900) pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869) pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893) pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825) pythonGH-81057: remove static state from suggestions.c (python#99411) Improve zip64 limit error message (python#95892) pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591) pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128) pythongh-82836: fix private network check (python#97733) Docs: improve accuracy of socketserver reference (python#24767) ...
