Add ABCMeta to Distribution. Fixes #419.

python · Jan 1, 2023 · 8a9d169 · 8a9d169
1 parent 1bf8a7a
commit 8a9d169
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/importlib_metadata/__init__.py b/importlib_metadata/__init__.py
@@ -346,7 +346,7 @@ def __repr__(self):
         return f'<FileHash mode: {self.mode} value: {self.value}>'
 
 
-class Distribution:
+class Distribution(metaclass=abc.ABCMeta):
     """A Python distribution package."""
 
     @abc.abstractmethod

diff --git a/tests/test_main.py b/tests/test_main.py
@@ -44,9 +44,8 @@ def test_package_not_found_mentions_metadata(self):
         assert "metadata" in str(ctx.exception)
 
     def test_abc_enforced(self):
-        with self.assertRaises(AssertionError):  # xfail
-            with self.assertRaises(TypeError):
-                type('DistributionSubclass', (Distribution,), {})()
+        with self.assertRaises(TypeError):
+            type('DistributionSubclass', (Distribution,), {})()
 
     @fixtures.parameterize(
         dict(name=None),