Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typed_ast mypy's default and only parser #1353

Closed
2 of 6 tasks
ddfisher opened this issue Apr 8, 2016 · 6 comments
Closed
2 of 6 tasks

Make typed_ast mypy's default and only parser #1353

ddfisher opened this issue Apr 8, 2016 · 6 comments
Assignees
Labels

Comments

@ddfisher
Copy link
Collaborator

ddfisher commented Apr 8, 2016

Currently, typed_ast is mypy's preferred parser (as it's much faster, more correct, and supports features like multiline type comments), but it is not yet mypy's default parser. The main blocker to this is Windows support.

Here are the high-level items remaining:

  • make typed_ast compile and run correctly on Windows
  • autobuild Windows wheels with AppVeyor
  • [optional] autobuild OS X wheels in TravisCI
  • update tests to account for minor line differences between typed_ast and the current parser
  • make typed_ast the default parser
  • remove old parser
@ddfisher ddfisher self-assigned this Apr 8, 2016
@ddfisher ddfisher added this to the 0.3.2 milestone Apr 8, 2016
@ddfisher
Copy link
Collaborator Author

ddfisher commented Apr 8, 2016

After this is complete, we can start converting mypy to use typed_ast's ast (which is very similar to the official python ast) node by node (which will further help perf).

@ddfisher
Copy link
Collaborator Author

typed_ast code now available at https://github.com/dropbox/typed_ast

@gvanrossum
Copy link
Member

@ddfisher: I've created a label "New Parser" and added it to all issues that look like they would be fixed by the new parser or could be fixed once the new parser is the only parser.

@ddfisher ddfisher changed the title Switch to a faster parser based on CPython's ast module Make typed_ast mypy's default and only parser Oct 19, 2016
@ddfisher
Copy link
Collaborator Author

The progress of making typed_ast compile and run on Windows is being tracked in this issue: python/typed_ast#20

@ethanhs
Copy link
Collaborator

ethanhs commented Jan 6, 2017

Since typed_ast now supports Windows fully, would there be interest in me working on appveyor integration? I know it was tried previously, but once this is completed, I see no reason why it shouldn't be added.

@gvanrossum
Copy link
Member

Yes @ethanhs we would it if you could contribute Appveyor integration! I once tried but didn't understand how it was supposed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants