Friendlier errors for PEP 612 #12832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| @@ -944,9 +944,9 @@ def analyze_callable_type(self, t: UnboundType) -> Type: | |||
| ) | |||
| if maybe_ret is None: | |||
| # Callable[?, RET] (where ? is something invalid) | |||
| # TODO(PEP612): change error to mention paramspec, once we actually have some | |||
There was a problem hiding this comment.
Though that's getting a bit much for an error message.
There was a problem hiding this comment.
I like the new language, maybe a note linking to some docs would be useful in addition however.
There was a problem hiding this comment.
Yeah, Concatenate is why I went with the more generic "parameter specification" rather than "ParamSpec". This error is probably disproportionately encountered by new users, so don't want it to be too scary.
I could add a note for https://mypy.readthedocs.io/en/stable/kinds_of_types.html#callable-types-and-lambdas
hauntsaninja
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This was referenced May 22, 2022
JukkaL
approved these changes
May 23, 2022
JukkaL
pushed a commit
that referenced
this pull request
May 23, 2022
Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.