Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with nested attrs class #12872

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix crash with nested attrs class #12872

merged 1 commit into from
May 26, 2022

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented May 26, 2022

Fixes #12868.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL merged commit 0054046 into master May 26, 2022
@JukkaL JukkaL deleted the fix-attrs-crash branch May 26, 2022 13:43
JukkaL added a commit that referenced this pull request May 30, 2022
@JukkaL
Fix crash with nested attrs class (#12872)
f649e2d 
Fixes #12868.
@dhuckins
Copy link

dhuckins commented Jun 1, 2022

running into an issue related to #12868
is there a timeline for including this change in the next release?

@JukkaL JukkaL mentioned this pull request Jun 6, 2022
Closed
@mr-c
Copy link
Contributor

mr-c commented Jun 8, 2022

running into an issue related to #12868 is there a timeline for including this change in the next release?

mypy 0.961 has been released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertionError on version 0.960
4 participants
@JukkaL @dhuckins @mr-c @ilevkivskyi