Fix incompatible overrides of overloaded generics with self types #14882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#14866 Basically does the potential todo I'd mentioned in python#14017
JelleZijlstra
approved these changes
Mar 11, 2023
|
Diff from mypy_primer, showing the effect of this PR on open source code: werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/datastructures/mixins.pyi:83: error: Unused "type: ignore" comment
+ src/werkzeug/datastructures/headers.pyi:91: error: Unused "type: ignore" comment
mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
+ bson/son.py: note: At top level:
+ bson/son.py:118: error: Unused "type: ignore" comment
urllib3 (https://github.com/urllib3/urllib3)
+ src/urllib3/_collections.py:269: error: Unused "type: ignore" comment
|
|
Nice to see this fixes more issues in real code! |
This was referenced Mar 12, 2023
Merged
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Apr 13, 2023
hauntsaninja
added a commit
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14866
Basically does the potential todo I'd mentioned in #14017