Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function compatibility rewrite #2521

Merged
merged 18 commits into from
Dec 22, 2016
Merged

Function compatibility rewrite #2521

merged 18 commits into from
Dec 22, 2016

Commits on Dec 21, 2016

  1. New algorithm for checking function compatibility. 

    The new algorithm correctly handles argument names.  It pays attention to them
when matching up arguments for function assignments, but not for overrides
(because too many libraries vary the agument names between superclass and
subclass).

I'll include a full writeup in prose of the new algorithm in the pull request.

Print callable types with named arguments differently from each other when important

Fix importFunctionAndAssignFunction test to match var names
    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    bb05f3c View commit details
    Browse the repository at this point in the history

  2. Rename argument shorter

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    8b3b788 View commit details
    Browse the repository at this point in the history

  3. Explain what i am doing better

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    5e68ee3 View commit details
    Browse the repository at this point in the history

  4. Stop checking argument names for multiple base classes

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    8bf9c53 View commit details
    Browse the repository at this point in the history

  5. Elide __foo argument names from funcs where args are not typed

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    1e4d467 View commit details
    Browse the repository at this point in the history

  6. Cosmetic

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    c42bd86 View commit details
    Browse the repository at this point in the history

  7. Make the text descriptions of args more concise

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    c8d4458 View commit details
    Browse the repository at this point in the history

  8. Account for one left argument with two corresponding right args

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    d7df8cd View commit details
    Browse the repository at this point in the history

  9. cosmetic

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    d811a82 View commit details
    Browse the repository at this point in the history

  10. cosmetic

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    95d1c58 View commit details
    Browse the repository at this point in the history

  11. Remove In class foo

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    d752499 View commit details
    Browse the repository at this point in the history

  12. Factor out corresponding_argument method

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    499e1d2 View commit details
    Browse the repository at this point in the history

  13. Optional for the name and pos

    @sixolet
    sixolet committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    7617eac View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2016

  1. typo

    @sixolet
    sixolet committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    77c8f73 View commit details
    Browse the repository at this point in the history

  2. Ignore implicitly typed function arg names

    @sixolet
    sixolet committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    62fd868 View commit details
    Browse the repository at this point in the history

  3. Test for ignoring arg names for implicit defs

    @sixolet
    sixolet committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    5c6d574 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @sixolet
    sixolet committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    4397926 View commit details
    Browse the repository at this point in the history

  5. Delete tests for implicit callable lacking names as they make no sens… 

    …e now
    @sixolet
    sixolet committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    2a07da8 View commit details
    Browse the repository at this point in the history