Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 599: manylinux2014 PEP #1121

Merged
merged 10 commits into from
Jul 20, 2019
Merged

PEP 599: manylinux2014 PEP #1121

merged 10 commits into from
Jul 20, 2019

Conversation

di
Copy link
Member

@di di commented Jul 10, 2019

pep-9999.rst Outdated Show resolved Hide resolved
pep-9999.rst Outdated Show resolved Hide resolved
brettcannon
brettcannon previously approved these changes Jul 11, 2019
@brettcannon brettcannon requested review from brettcannon and removed request for brettcannon July 11, 2019 19:43
@brettcannon brettcannon dismissed their stale review July 11, 2019 19:44

Accidentally approved a single commit

@brettcannon brettcannon removed their request for review July 11, 2019 19:44
@di
Copy link
Member Author

di commented Jul 11, 2019

@brettcannon Did you mean to approve the entire PR?

@brettcannon
Copy link
Member

@di if you look at the issue history you will see I dismissed my review with the comment "accidentally approved" 😁 .

@di
Copy link
Member Author

di commented Jul 18, 2019

This has been open for 1 week without additional comments. Can someone assign this a PEP # and merge? @brettcannon / @pfmoore / @ncoghlan?

pep-9999.rst Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member

@di at this point you just need to add a sponsor.

@di
Copy link
Member Author

di commented Jul 18, 2019

@pfmoore, are you willing to act as "sponsor" here?

@pfmoore
Copy link
Member

pfmoore commented Jul 18, 2019

Given that I'm deciding between the 2 alternative proposals, is that appropriate? @brettcannon what's your view here? If it's OK for the BDFL-delegate to also be the sponsor, I'm fine with sponsoring this (although I'd have to say, I'm not entirely sure what the role of sponsor involves).

@di
Copy link
Member Author

di commented Jul 18, 2019

PEP 1 says:

The sponsor's job is to provide guidance to the PEP author to help them through the logistics of the PEP process (somewhat acting like mentor). For the core developer sponsoring, being a sponsor does not disqualify them from becoming a co-author or BDFL-Delegate later on

So, more or less a formality here it seems, given that the "PEP process" is mostly completed.

pep-9999.rst Outdated Show resolved Hide resolved
pep-9999.rst Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member

@pfmoore as @di quoted, a sponsor acts as a mentor/guide to someone going through the PEP process. You could be totally for/against the PEP and still be a sponsor to help Dustin with the overall process.

@pfmoore
Copy link
Member

pfmoore commented Jul 19, 2019

Cool - @di I'm happy to be the sponsor in that case.

@ncoghlan ncoghlan self-assigned this Jul 20, 2019
@ncoghlan
Copy link
Contributor

Assigning 599 and 600 to this PEP and the perennial manylinux proposal.

@ncoghlan ncoghlan changed the title manylinux2014 PEP PEP 599: manylinux2014 PEP Jul 20, 2019
@ncoghlan ncoghlan merged commit a5edd3d into python:master Jul 20, 2019
@di di deleted the manylinux2014 branch July 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants