Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 728: Revise proposal to spec the 'extra_items=T' idea #4066

Merged
merged 6 commits into from
Oct 19, 2024
Merged

PEP 728: Revise proposal to spec the 'extra_items=T' idea #4066

merged 6 commits into from
Oct 19, 2024

Commits on Oct 18, 2024

  1. Revise proposal to spec the 'extra_items=T' idea 

    - Move away from '__extra_items__: T' to 'extra_items=T'

- Repurpose the 'closed' class parameter to make 'closed=True'
  an alias of 'extra_items=Never'

- Include references to the typing spec

- Normalize terms like "assignability" and "consistent" to match the
  typing glossary (https://typing.readthedocs.io/en/latest/spec/glossary.html)

- Update sections that contain documentation quotes to match the
  up-to-date version

- Add new sections about other ideas

- Bump the target version to 3.14
    @PIG208
    PIG208 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b1f4d8d View commit details
    Browse the repository at this point in the history

  2. Address feedback from Jelle. 

    Some of the linked sections do not expose the label, otherwise we should
be able to use intersphinx references.

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c321b30 View commit details
    Browse the repository at this point in the history

  3. Allow 'closed=False'; define its behavior 

    Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    527a5ed View commit details
    Browse the repository at this point in the history

  4. Use 'typing:' prefix for term references. 

    Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cbc5813 View commit details
    Browse the repository at this point in the history

  5. Incorporate Jelle's comment on the '__items__' idea 

    python#4066 (comment)

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208
    PIG208 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    edf3882 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Update peps/pep-0728.rst

    @JelleZijlstra
    JelleZijlstra authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9a8c0b7 View commit details
    Browse the repository at this point in the history