Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyUnicode_EqualToUTF8() function #78

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add PyUnicode_EqualToUTF8() function #78

merged 1 commit into from
Oct 12, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 4, 2023

No description provided.

@vstinner vstinner marked this pull request as draft October 4, 2023 14:46
@vstinner
Copy link
Member Author

vstinner commented Oct 4, 2023

Wait until the API is added upstream: python/cpython#110297

@vstinner vstinner mentioned this pull request Oct 4, 2023
Merged
@serhiy-storchaka
Copy link
Member

You need to at least save and restore the exception as in PyDict_GetItem().

@vstinner vstinner marked this pull request as ready for review October 12, 2023 09:39
@vstinner
Add PyUnicode_EqualToUTF8() function
5cca9a4 
Add PyUnicode_EqualToUTF8() and PyUnicode_EqualToUTF8AndSize()
functions.
@vstinner vstinner merged commit 99ab0d3 into python:main Oct 12, 2023
21 checks passed
@vstinner vstinner deleted the equalutf8 branch October 12, 2023 10:00
@vstinner
Copy link
Member Author

You need to at least save and restore the exception as in PyDict_GetItem().

Right, done. I added a test for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @serhiy-storchaka