This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Distinguish 'x' and b'x' in Python 2 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am happy with this. @ddfisher, would you mind merging this once you're back from your vacation? It won't require mypy changes (but it enables some that I am going to work on). |
|
Oh, before merging, please update version in setup.py. |
|
@gvanrossum |
|
Yeah, if both get merged around the same time we only need one version
increment. It's up to @ddfisher at this point. (David: note that GitHub
added a feature to allow reviewers to edit PRs in the web UI. Very cool!)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
@gvanrossum @JukkaL @ddfisher
This is a naive fix. It only checks the first string in concatenation at CST level, for
borBprefix and sets thehas_bflag inStrAST node accordingly.