-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document "the Any trick" #11117
Document "the Any trick" #11117
Conversation
+1 for adding docs first — it doesn't preclude adding an alias at a later date, and it's easier to get consensus on! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pile of small nits that should make this easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty good. A few more nits.
Co-authored-by: Akuli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but another review would be good IMO.
Addresses the documentation part of #11094 .
Copied almost directly from #7770 (comment) just to get the ball rolling.
Wordsmith away! I don't feel strongly about any particular description, as long as it ends up documented and explained!
I'm not including an alias here because getting "the Any trick" documented at all is the most important part we all agreed on. I also noticed that it's not always clear why an
Any
union is used. So an alias for those cases should definitely help, but will require some thinking over changes. When creating the alias, it can immediately be used in stdlib as well. And a small mention can be added to the this here documentation. Something like: