Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all params positional-only in slice.__new__ #12900

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Make all params positional-only in slice.__new__ #12900

merged 1 commit into from
Oct 24, 2024

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz randolf-scholz mentioned this pull request Oct 24, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood changed the title positional only __new__ Make all params positional-only in slice.__new__ Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 1018323 into python:main Oct 24, 2024
63 checks passed
@randolf-scholz randolf-scholz mentioned this pull request Oct 24, 2024
Merged
@randolf-scholz randolf-scholz deleted the slice_positional_only branch October 24, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randolf-scholz @AlexWaygood