a close reading of the pickle module #12971
Open
+157
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
tungol
commented
Nov 7, 2024
Comment on lines
+12
to
+16
| # This protocol approximates the undocumented PicklerMemoProxy | ||
| # and UnpicklerMemoProxy types. | ||
| class _MemoProxy(Protocol): | ||
| def clear(self, /) -> None: ... | ||
| def copy(self, /) -> dict[int, tuple[int, Any]]: ... |
There was a problem hiding this comment.
I'm of two minds here. I like the protocol for the getter return type; it avoids having the PicklerMemoProxy class in the stubs, where it could imply it's importable, and it isn't. I might feel better about that if it was named _PicklerMemoProxy, but alas.
I dislike the protocol for the setter value, because that method actually does do an identity check on PicklerMemoProxy or UnpicklerMemoProxy, depending.
I have been pondering this since I opened the MR, and have flipped back and forth which I think is better a couple times now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't go in planning to split the C
_pickle.Pickerand pythonpickle._Picklerimplementations, but then the _Pickler-only classvar was there and I didn't like copying that into _pickle.pyi.Pickler.memo and Unpickler.memo I went as far as I did with it because of the comment here: https://github.com/python/cpython/blob/3.12/Modules/_pickle.c#L4839
which pretty strongly implies that somebody out there is using it.