Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Any, not Union from IP parsing functions #2499

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Return Any, not Union from IP parsing functions #2499

merged 1 commit into from
Oct 1, 2018

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Oct 1, 2018

Closes: #2080

@JelleZijlstra JelleZijlstra merged commit 7be20fc into python:master Oct 1, 2018
@srittau srittau deleted the ipaddress branch October 16, 2018 01:29
@srittau
Copy link
Collaborator Author

srittau commented Oct 16, 2018

This is a good example, where an AnyOf return type (python/typing#566) would be helpful.

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@srittau
Return Any, not Union from IP parsing functions (python#2499)
df011b8 
Closes: python#2080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @JelleZijlstra