Improve imaplib return types #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark CommandResults as obsolete. Also fix types of tagged_commands and untagged_responses. Based on a discussion in python#3655.
|
@JelleZijlstra I tried to figure the response types with a mix of experiments and reading the (rather hard to follow) code. I am reasonably content that they are correct. |
|
I am a bit confused, why CI is even running stubtest, as this branch precedes stubtest. .travis.yml for this branch does not include stubtest and there is no tests/stubtest_whitelists directory to reference. Anyway, I am restarting CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark CommandResults as obsolete.
Also fix types of tagged_commands and untagged_responses.
Based on a discussion in #3655.